Add information about risks associated with giving super user access to a user #22554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkleiner
added
Enhancement
michalkleiner
force-pushed
the
dev-18465
branch
2 times, most recently
from
375d5d7
to
456cb7f
Compare
caddoo
previously approved these changes
Sep 12, 2024
sgiehl
reviewed
Sep 12, 2024
plugins/UsersManager/tests/UI/expected-screenshots/UsersManager_superuser_confirm.png
Outdated
Show resolved
Hide resolved
sgiehl
dismissed
caddoo’s stale review
UI tests are failing due to the changes in this PR
sgiehl
approved these changes
Sep 13, 2024
michalkleiner
added a commit
that referenced
this pull request
Sep 13, 2024
…to a user (#22554) * Add information about risks associated with giving super user access to a user * Update risks to allow ActivityLog plugin upsell and link to it when activated * Update UI test screenshots * Add UI tests with ActivityLog and without Marketplace * Tweak UI test spec * Update UI test screenshots * Update UI test screenshots from CI run * Ensure to reload the user manager page after changing plugins config * Reset modal confirmation UI test screenshot * Use the same modal screenshot approach as used elsewhere in the suite
Merged
11 tasks
mneudert
pushed a commit
that referenced
this pull request
Sep 13, 2024
…to a user (#22554) (#22589) * Add information about risks associated with giving super user access to a user * Update risks to allow ActivityLog plugin upsell and link to it when activated * Update UI test screenshots * Add UI tests with ActivityLog and without Marketplace * Tweak UI test spec * Update UI test screenshots * Update UI test screenshots from CI run * Ensure to reload the user manager page after changing plugins config * Reset modal confirmation UI test screenshot * Use the same modal screenshot approach as used elsewhere in the suite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add information about risks associated with giving super user access to a user. There's a difference in the copy based on what plugins the instance has enabled.
Ref. DEV-18465
Review