Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /_dendrite/admin/refreshDevices/{userID} #2746

Merged
merged 4 commits into from
Sep 30, 2022
Merged

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Sep 28, 2022

Allows to immediately query /devices/{userID} over federation to (hopefully) resolve E2EE issues.

@S7evinK S7evinK requested a review from a team as a code owner September 28, 2022 17:33
Copy link
Contributor

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realise internally we refer to it as “marking as stale” but it might be better for this endpoint to be named something that explains what it does, like “refresh device list”.

@S7evinK
Copy link
Contributor Author

S7evinK commented Sep 29, 2022

Right, had the same thought after having closed my notebook.

@S7evinK S7evinK changed the title Add /_dendrite/admin/markAsStale/{userID} Add /_dendrite/admin/refreshDevices/{userID} Sep 29, 2022
@neilalexander neilalexander merged commit 9005e5b into main Sep 30, 2022
@neilalexander neilalexander deleted the s7evink/adminstale branch September 30, 2022 08:32
@Mic92
Copy link

Mic92 commented Nov 4, 2022

Do I need to put in my own userid or the other persons userid in the http endpoint?

@S7evinK
Copy link
Contributor Author

S7evinK commented Nov 4, 2022

Do I need to put in my own userid or the other persons userid in the http endpoint?

Of the other user, the userID you want to refresh. If you try to use a local userID, you should get an error message.

@Mic92
Copy link

Mic92 commented Nov 4, 2022

Ok. If I have a room, should refreshing keys for specified user also help with an encrypted room work or is room encryption completely disconnected from this? Because I tried this endpoint and the other person was still not able to read my messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants