-
-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs restructure #2953
Docs restructure #2953
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2953 +/- ##
==========================================
- Coverage 66.49% 66.11% -0.39%
==========================================
Files 499 499
Lines 53790 53799 +9
==========================================
- Hits 35770 35569 -201
- Misses 14484 14636 +152
- Partials 3536 3594 +58
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
defer close() | ||
defer func() { | ||
// give components the time to process purge requests | ||
time.Sleep(time.Millisecond * 50) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this will still be quite flakey. Is there a better way to handle this in the test?
|
||
```yaml | ||
global: | ||
# ... | ||
database: | ||
connection_string: postgres://user:pass@hostname/database?sslmode=disable | ||
max_open_conns: 100 | ||
max_open_conns: 90 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of curiosity, why the change in number here? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned, the default configuration for Postgres is set to 100, but has reserved 3 slots for administrative usage. So having 90 conns for Dendrite sounds like a fair trade. (Even though we probably could go further down)
Needs to be merged into
gh-pages
later on.