Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs restructure #2953

Merged
merged 23 commits into from
May 30, 2023
Merged

Docs restructure #2953

merged 23 commits into from
May 30, 2023

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Jan 26, 2023

Needs to be merged into gh-pages later on.

@S7evinK S7evinK requested a review from a team as a code owner January 26, 2023 12:06
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.39 ⚠️

Comparison is base (11b5570) 66.49% compared to head (08502f2) 66.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2953      +/-   ##
==========================================
- Coverage   66.49%   66.11%   -0.39%     
==========================================
  Files         499      499              
  Lines       53790    53799       +9     
==========================================
- Hits        35770    35569     -201     
- Misses      14484    14636     +152     
- Partials     3536     3594      +58     
Flag Coverage Δ
unittests 49.90% <100.00%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
clientapi/routing/admin.go 57.61% <100.00%> (+0.20%) ⬆️
roomserver/internal/perform/perform_admin.go 40.90% <100.00%> (+1.92%) ⬆️
syncapi/storage/sqlite3/account_data_table.go 77.61% <100.00%> (-4.48%) ⬇️

... and 45 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

defer close()
defer func() {
// give components the time to process purge requests
time.Sleep(time.Millisecond * 50)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this will still be quite flakey. Is there a better way to handle this in the test?

docs/INSTALL.md Outdated Show resolved Hide resolved
docs/INSTALL.md Outdated Show resolved Hide resolved

```yaml
global:
# ...
database:
connection_string: postgres://user:pass@hostname/database?sslmode=disable
max_open_conns: 100
max_open_conns: 90
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity, why the change in number here? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned, the default configuration for Postgres is set to 100, but has reserved 3 slots for administrative usage. So having 90 conns for Dendrite sounds like a fair trade. (Even though we probably could go further down)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants