Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app service unix socket support #3022

Merged
merged 3 commits into from
Apr 4, 2023
Merged

app service unix socket support #3022

merged 3 commits into from
Apr 4, 2023

Conversation

cyberb
Copy link
Contributor

@cyberb cyberb commented Mar 20, 2023

This is the last part of unix socket support to talk to app servers, go based app services already support unix sockets:
mautrix/go@5a68173

appservice:
  # The address that the homeserver can use to connect to this appservice.
  address: unix:///var/snap/matrix/current/whatsapp.socket

  # The hostname and port where this appservice should listen.
  hostname: /var/snap/matrix/current/whatsapp.socket
  port: 0

Pull Request Checklist

Signed-off-by: Boris Rybalkin <ribalkin@gmail.com>

@cyberb cyberb requested a review from a team as a code owner March 20, 2023 19:00
@cyberb cyberb force-pushed the main branch 3 times, most recently from 388886d to 5b22bf2 Compare March 21, 2023 13:29
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch coverage: 79.54% and project coverage change: -0.15 ⚠️

Comparison is base (682a7d0) 66.75% compared to head (40d04c5) 66.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3022      +/-   ##
==========================================
- Coverage   66.75%   66.60%   -0.15%     
==========================================
  Files         495      495              
  Lines       53532    53548      +16     
==========================================
- Hits        35736    35668      -68     
- Misses      14197    14263      +66     
- Partials     3599     3617      +18     
Flag Coverage Δ
unittests 46.21% <79.54%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
appservice/query/query.go 65.15% <60.00%> (ø)
appservice/consumers/roomserver.go 64.73% <66.66%> (-0.21%) ⬇️
setup/config/config_appservice.go 66.35% <86.20%> (+2.67%) ⬆️
appservice/appservice.go 78.43% <100.00%> (-3.54%) ⬇️

... and 22 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cyberb
Copy link
Contributor Author

cyberb commented Mar 25, 2023

is it possible to review this branch as I need to rebase every few days now?

Copy link
Contributor

@S7evinK S7evinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a few more tests to check that we can connect to an appservice using unix sockets.
Probably TestAppserviceInternalAPI can be copied and changed to listen on a unix socket instead of a HTTP server.

Otherwise looks sane to me.

setup/config/config_appservice.go Outdated Show resolved Hide resolved
@cyberb
Copy link
Contributor Author

cyberb commented Mar 30, 2023

@S7evinK could you check please?

@cyberb
Copy link
Contributor Author

cyberb commented Apr 3, 2023

can someone check this?

setup/config/config_appservice.go Outdated Show resolved Hide resolved
@S7evinK
Copy link
Contributor

S7evinK commented Apr 4, 2023

Thanks for this!

@S7evinK S7evinK merged commit 985298c into matrix-org:main Apr 4, 2023
@cyberb
Copy link
Contributor Author

cyberb commented Apr 4, 2023

Thank you very much for the great support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants