-
-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove BaseDendrite
#3023
Remove BaseDendrite
#3023
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3023 +/- ##
==========================================
+ Coverage 63.24% 63.40% +0.16%
==========================================
Files 497 497
Lines 53851 53745 -106
==========================================
+ Hits 34058 34077 +19
+ Misses 16100 16014 -86
+ Partials 3693 3654 -39
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 47 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an improvement on the status quo because we now have each component only accepting what they actually need rather than BaseDendrite
everywhere. The component constructors are still very complex at present, but we can make composable intermediate structs in another PR. LGTM
Removes
BaseDendrite
to, hopefully, make testing and composing of components easier in the future.