Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BaseDendrite #3023

Merged
merged 24 commits into from
Mar 22, 2023
Merged

Remove BaseDendrite #3023

merged 24 commits into from
Mar 22, 2023

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Mar 21, 2023

Removes BaseDendrite to, hopefully, make testing and composing of components easier in the future.

@S7evinK S7evinK added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Mar 21, 2023
@S7evinK S7evinK marked this pull request as ready for review March 21, 2023 14:39
@S7evinK S7evinK requested a review from a team as a code owner March 21, 2023 14:39
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch coverage: 80.22% and project coverage change: +0.16 🎉

Comparison is base (ec6879e) 63.24% compared to head (a09828b) 63.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3023      +/-   ##
==========================================
+ Coverage   63.24%   63.40%   +0.16%     
==========================================
  Files         497      497              
  Lines       53851    53745     -106     
==========================================
+ Hits        34058    34077      +19     
+ Misses      16100    16014      -86     
+ Partials     3693     3654      -39     
Flag Coverage Δ
unittests 42.85% <80.22%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/dendrite/main.go 75.00% <ø> (-5.00%) ⬇️
roomserver/internal/alias.go 53.19% <0.00%> (-2.84%) ⬇️
roomserver/internal/input/input.go 77.44% <0.00%> (+4.68%) ⬆️
setup/base/sanity_unix.go 27.27% <0.00%> (-4.55%) ⬇️
setup/jetstream/nats.go 52.22% <0.00%> (-1.32%) ⬇️
setup/base/base.go 52.66% <38.09%> (-4.43%) ⬇️
mediaapi/routing/routing.go 71.15% <50.00%> (-1.93%) ⬇️
setup/mscs/msc2836/msc2836.go 42.71% <75.00%> (ø)
clientapi/routing/routing.go 54.61% <77.77%> (-0.01%) ⬇️
federationapi/routing/routing.go 77.35% <80.00%> (-0.24%) ⬇️
... and 16 more

... and 47 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@kegsay kegsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an improvement on the status quo because we now have each component only accepting what they actually need rather than BaseDendrite everywhere. The component constructors are still very complex at present, but we can make composable intermediate structs in another PR. LGTM

@S7evinK S7evinK enabled auto-merge (squash) March 22, 2023 07:57
@S7evinK S7evinK disabled auto-merge March 22, 2023 08:16
@S7evinK S7evinK merged commit 5e85a00 into main Mar 22, 2023
@S7evinK S7evinK deleted the s7evink/baserefactor branch March 22, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants