Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use latest GMSL which splits fed client from matrix room logic #3051

Merged
merged 3 commits into from
Apr 6, 2023

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented Apr 5, 2023

Part of a series of refactors on GMSL.

@kegsay kegsay added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Apr 5, 2023
@kegsay kegsay requested a review from a team as a code owner April 5, 2023 17:18
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch coverage: 24.74% and project coverage change: -0.28 ⚠️

Comparison is base (e093005) 66.50% compared to head (16ac370) 66.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3051      +/-   ##
==========================================
- Coverage   66.50%   66.22%   -0.28%     
==========================================
  Files         497      497              
  Lines       53633    53639       +6     
==========================================
- Hits        35669    35525     -144     
- Misses      14300    14442     +142     
- Partials     3664     3672       +8     
Flag Coverage Δ
unittests 46.26% <24.74%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
clientapi/clientapi.go 100.00% <ø> (ø)
clientapi/routing/directory.go 59.33% <ø> (ø)
clientapi/routing/profile.go 54.09% <ø> (ø)
clientapi/routing/routing.go 61.12% <ø> (ø)
clientapi/routing/userdirectory.go 65.75% <ø> (ø)
cmd/dendrite-demo-pinecone/rooms/rooms.go 12.69% <0.00%> (ø)
cmd/dendrite-demo-pinecone/users/users.go 8.69% <ø> (ø)
cmd/dendrite/main.go 59.23% <ø> (+0.13%) ⬆️
federationapi/api/api.go 100.00% <ø> (ø)
federationapi/federationapi.go 77.14% <ø> (ø)
... and 46 more

... and 14 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kegsay kegsay merged commit 0db43f1 into main Apr 6, 2023
@kegsay kegsay deleted the kegan/gmsl-types branch April 6, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants