Remove PerformError

[S7evinK]

This removes PerformError, which was needed when we still had polylith.

This removes quite a bunch of

if err != nil {
	return err
}
if err := res.Error; err != nil {
	return err.JSONResponse()
}

Hopefully can be read commit by commit.

[codecov]

Codecov Report

Patch coverage: 40.31% and project coverage change: +0.19 🎉

Comparison is base (d23d036) 66.57% compared to head (9c4a605) 66.77%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3066      +/-   ##
==========================================
+ Coverage   66.57%   66.77%   +0.19%     
==========================================
  Files         496      497       +1     
  Lines       53525    53200     -325     
==========================================
- Hits        35634    35522     -112     
+ Misses      14275    14101     -174     
+ Partials     3616     3577      -39     

Flag	Coverage Δ
unittests	49.50% <40.31%> (+0.29%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
clientapi/routing/directory.go	60.08% <0.00%> (+0.74%)	⬆️
clientapi/routing/peekroom.go	31.34% <0.00%> (-16.81%)	⬇️
clientapi/routing/upgrade_room.go	51.51% <0.00%> (-26.54%)	⬇️
federationapi/routing/invite.go	41.17% <0.00%> (-5.23%)	⬇️
roomserver/api/perform.go	100.00% <ø> (+11.36%)	⬆️
roomserver/internal/perform/perform_peek.go	42.20% <0.00%> (+1.35%)	⬆️
roomserver/internal/perform/perform_unpeek.go	0.00% <0.00%> (ø)
userapi/internal/user_api.go	62.87% <0.00%> (-0.26%)	⬇️
roomserver/internal/perform/perform_invite.go	74.09% <16.66%> (+1.40%)	⬆️
clientapi/routing/createroom.go	60.70% <37.50%> (-0.54%)	⬇️
... and 10 more

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[kegsay]

Clearer API overall, LGTM!

[kegsay]

This probably isn't a "not allowed" error? It used to be err no op.

[S7evinK]

PerformErrorNoOperation also returned a http.StatusForbidden in the end, so this should end up being the same error code for clients.