Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PDU not *Event in HeaderedEvent #3073

Merged
merged 5 commits into from
May 2, 2023
Merged

Use PDU not *Event in HeaderedEvent #3073

merged 5 commits into from
May 2, 2023

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented May 2, 2023

Requires matrix-org/gomatrixserverlib#376

This has numerous upsides:

  • Less type casting to *Event is required.
  • Making Dendrite work with PDU interfaces means we can swap out Event impls more easily.
  • Tests which represent weird event shapes are easier to write.

Part of a series of refactors on GMSL.

@kegsay kegsay added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label May 2, 2023
@kegsay kegsay requested a review from a team as a code owner May 2, 2023 10:18
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch coverage: 37.27% and project coverage change: -0.20 ⚠️

Comparison is base (696cbb7) 67.35% compared to head (6d1cbb1) 67.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3073      +/-   ##
==========================================
- Coverage   67.35%   67.16%   -0.20%     
==========================================
  Files         497      497              
  Lines       53137    53140       +3     
==========================================
- Hits        35791    35690     -101     
- Misses      13772    13876     +104     
  Partials     3574     3574              
Flag Coverage Δ
unittests 50.05% <37.27%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
appservice/consumers/roomserver.go 71.09% <0.00%> (ø)
clientapi/routing/aliases.go 69.49% <0.00%> (-2.93%) ⬇️
clientapi/routing/directory.go 60.08% <0.00%> (-0.43%) ⬇️
clientapi/routing/sendevent.go 70.85% <0.00%> (-2.70%) ⬇️
clientapi/routing/server_notices.go 70.44% <0.00%> (ø)
federationapi/internal/federationclient.go 54.07% <ø> (ø)
federationapi/routing/backfill.go 57.31% <0.00%> (-3.66%) ⬇️
federationapi/routing/events.go 42.22% <0.00%> (-4.45%) ⬇️
federationapi/routing/invite.go 43.52% <0.00%> (-0.59%) ⬇️
federationapi/routing/join.go 53.00% <0.00%> (-1.31%) ⬇️
... and 37 more

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kegsay kegsay merged commit f5b3144 into main May 2, 2023
@kegsay kegsay deleted the kegan/pdu4 branch May 2, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant