Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PDU in even more places #3074

Merged
merged 3 commits into from
May 3, 2023
Merged

Use PDU in even more places #3074

merged 3 commits into from
May 3, 2023

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented May 3, 2023

  • No longer rely on *Event returning from NewEventFrom... functions

Requires matrix-org/gomatrixserverlib#377

- No longer rely on *Event returning from NewEventFrom... functions
@kegsay kegsay added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label May 3, 2023
@kegsay kegsay requested a review from a team as a code owner May 3, 2023 08:29
kegsay added 2 commits May 3, 2023 09:37
Also remove unused interface in federationapi
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: +0.03 🎉

Comparison is base (9b98e5a) 67.10% compared to head (27905ec) 67.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3074      +/-   ##
==========================================
+ Coverage   67.10%   67.14%   +0.03%     
==========================================
  Files         497      497              
  Lines       53140    53140              
==========================================
+ Hits        35662    35682      +20     
+ Misses      13874    13860      -14     
+ Partials     3604     3598       -6     
Flag Coverage Δ
unittests 50.19% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
federationapi/routing/send.go 68.05% <ø> (ø)
federationapi/routing/threepid.go 0.00% <0.00%> (ø)
roomserver/internal/input/input_missing.go 68.20% <0.00%> (-0.15%) ⬇️
syncapi/notifier/notifier.go 80.20% <ø> (ø)
clientapi/routing/createroom.go 63.52% <100.00%> (ø)
federationapi/federationapi.go 77.14% <100.00%> (ø)
federationapi/routing/routing.go 77.59% <100.00%> (ø)
internal/caching/cache_roomevents.go 100.00% <100.00%> (ø)
internal/caching/impl_ristretto.go 90.78% <100.00%> (ø)
roomserver/internal/helpers/helpers.go 66.96% <100.00%> (ø)
... and 3 more

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@S7evinK S7evinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kegsay kegsay merged commit 6284790 into main May 3, 2023
@kegsay kegsay deleted the kegan/pdu5 branch May 3, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants