Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SendJoin logic to GMSL #3084

Merged
merged 11 commits into from
May 19, 2023
Merged

Move SendJoin logic to GMSL #3084

merged 11 commits into from
May 19, 2023

Conversation

devonh
Copy link
Collaborator

@devonh devonh commented May 19, 2023

Moves the core matrix logic for handling the send_join endpoint over to gmsl.

@devonh devonh requested a review from a team as a code owner May 19, 2023 01:08
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 0.83% and project coverage change: -0.10 ⚠️

Comparison is base (027a9b8) 66.25% compared to head (efa4db3) 66.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3084      +/-   ##
==========================================
- Coverage   66.25%   66.15%   -0.10%     
==========================================
  Files         497      497              
  Lines       53793    53724      -69     
==========================================
- Hits        35640    35542      -98     
- Misses      14573    14608      +35     
+ Partials     3580     3574       -6     
Flag Coverage Δ
unittests 49.57% <0.83%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
federationapi/routing/join.go 27.79% <0.00%> (-19.02%) ⬇️
federationapi/routing/routing.go 72.60% <0.00%> (-2.91%) ⬇️
roomserver/api/api.go 100.00% <ø> (ø)
roomserver/internal/query/query.go 59.44% <100.00%> (-0.42%) ⬇️

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@devonh devonh merged commit 2eae8dc into main May 19, 2023
@devonh devonh deleted the sendjoin-refactor branch May 19, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants