-
-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: admin APIs for token authenticated registration #3101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As there are no tests in Sytest, would be awesome if you could add tests for this in Dendrite. :)
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3101 +/- ##
==========================================
+ Coverage 65.54% 65.65% +0.11%
==========================================
Files 502 504 +2
Lines 55192 55753 +561
==========================================
+ Hits 36174 36604 +430
- Misses 15256 15356 +100
- Partials 3762 3793 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a few changes, but this is promising :)
Comments for Postgres should also apply to SQLite.
As for the database functions, there is a bit of inconsistency here: Sometimes you're using sqlutil.TxStmt()
and sometimes you're using the "raw" statement.
Thanks @S7evinK - let me work on the comments |
@S7evinK Thanks for your valuable comments. I've addressed all of them |
@S7evinK PR is ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't have a look at the tests yet, doing that tomorrow.
@S7evinK - addressed all the comments. |
I added 2 comments about flipping logic around. Otherwise, once the linter errors are fixed this should be good to merge. |
Pull Request Checklist
Signed-off-by:
Santhoshivan Amudhan santhoshivan23@gmail.com