Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create user room key if needed #3108

Merged
merged 6 commits into from
Jun 13, 2023
Merged

Create user room key if needed #3108

merged 6 commits into from
Jun 13, 2023

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Jun 12, 2023

No description provided.

@S7evinK S7evinK added the T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. label Jun 12, 2023
@S7evinK S7evinK requested a review from a team as a code owner June 12, 2023 10:59
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage: 2.22% and project coverage change: -0.02 ⚠️

Comparison is base (82b73a4) 65.73% compared to head (d62c058) 65.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3108      +/-   ##
==========================================
- Coverage   65.73%   65.71%   -0.02%     
==========================================
  Files         502      502              
  Lines       54798    54841      +43     
==========================================
+ Hits        36019    36038      +19     
- Misses      15065    15090      +25     
+ Partials     3714     3713       -1     
Flag Coverage Δ
unittests 49.81% <2.22%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
roomserver/api/api.go 100.00% <ø> (ø)
roomserver/internal/api.go 86.66% <0.00%> (-7.88%) ⬇️
roomserver/internal/perform/perform_create_room.go 54.69% <0.00%> (-2.14%) ⬇️
roomserver/internal/perform/perform_invite.go 62.40% <0.00%> (-2.44%) ⬇️
roomserver/storage/shared/storage.go 67.74% <0.00%> (+0.71%) ⬆️
roomserver/internal/perform/perform_join.go 79.68% <14.28%> (-1.88%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@S7evinK S7evinK merged commit 2c87972 into main Jun 13, 2023
@S7evinK S7evinK deleted the s7evink/createuserroomkey branch June 13, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant