Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backfilling #3117

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Fix backfilling #3117

merged 2 commits into from
Jun 20, 2023

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Jun 20, 2023

This should fix two issues with backfilling:

  1. right after creating and joining a room over federation, we are doing a /backfill request, which would return redacted events, because the authEvents are empty. Even though the spec states that, in the absence of a history visibility event, it should be handled as shared.
  2. gomatrixserverlib: unsupported room version '' - because, well, we were never setting the roomInfo field..

@S7evinK S7evinK added the T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. label Jun 20, 2023
@S7evinK S7evinK requested a review from a team as a code owner June 20, 2023 14:05
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d13466c) 65.64% compared to head (11fed6e) 65.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3117   +/-   ##
=======================================
  Coverage   65.64%   65.64%           
=======================================
  Files         502      502           
  Lines       55198    55192    -6     
=======================================
- Hits        36234    36232    -2     
+ Misses      15221    15220    -1     
+ Partials     3743     3740    -3     
Flag Coverage Δ
unittests 49.69% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
roomserver/auth/auth.go 88.00% <ø> (-0.89%) ⬇️
roomserver/internal/perform/perform_backfill.go 49.78% <0.00%> (-1.08%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@S7evinK S7evinK linked an issue Jun 20, 2023 that may be closed by this pull request
@S7evinK S7evinK merged commit a734b11 into main Jun 20, 2023
16 of 18 checks passed
@S7evinK S7evinK deleted the s7evink/fixbackfill branch June 20, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to sync history unsupported room version
2 participants