Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate release binaries #3121

Merged
merged 0 commits into from
Aug 23, 2023
Merged

Automate release binaries #3121

merged 0 commits into from
Aug 23, 2023

Conversation

acheong08
Copy link
Contributor

Automatically upload build artifacts and attach to release.

Signed-off-by: Antonio Cheong <acheong@student.dalat.org>

@acheong08 acheong08 requested a review from a team as a code owner June 22, 2023 07:20
@acheong08
Copy link
Contributor Author

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.01% 🎉

Comparison is base (9a12420) 64.28% compared to head (1b12304) 65.29%.

❗ Current head 1b12304 differs from pull request most recent head 9a12420. Consider uploading reports for the commit 9a12420 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3121      +/-   ##
==========================================
+ Coverage   64.28%   65.29%   +1.01%     
==========================================
  Files         506      504       -2     
  Lines       57277    56215    -1062     
==========================================
- Hits        36821    36707     -114     
+ Misses      16622    15702     -920     
+ Partials     3834     3806      -28     
Flag Coverage Δ
unittests 49.75% <ø> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 93 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@S7evinK S7evinK merged commit 9a12420 into matrix-org:main Aug 23, 2023
46 of 100 checks passed
@acheong08
Copy link
Contributor Author

acheong08 commented Aug 23, 2023

Looks like pull bot force pushed and deleted the pull request then got it merged?

@S7evinK
Copy link
Contributor

S7evinK commented Aug 23, 2023

We're as confused as you, as this got automatically merged when I merged #3187

@acheong08
Copy link
Contributor Author

I successfully replicated this issue:

It happens when the branch is force pushed to a commit hash that has yet to be commited. It will automatically be merged if the commit is pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants