Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues reported by Sentry #3143

Merged
merged 7 commits into from
Jul 7, 2023
Merged

Fix issues reported by Sentry #3143

merged 7 commits into from
Jul 7, 2023

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Jul 7, 2023

This should fix a few issues reported by Sentry, e.g. HTTP500 when trying to update room keys which don't exist.

@S7evinK S7evinK added the T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. label Jul 7, 2023
@S7evinK S7evinK requested a review from a team as a code owner July 7, 2023 10:37
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c08c740) 65.24% compared to head (c8baa39) 65.24%.

❗ Current head c8baa39 differs from pull request most recent head 53df425. Consider uploading reports for the commit 53df425 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3143   +/-   ##
=======================================
  Coverage   65.24%   65.24%           
=======================================
  Files         504      504           
  Lines       56218    56218           
=======================================
  Hits        36680    36680           
- Misses      15717    15719    +2     
+ Partials     3821     3819    -2     
Flag Coverage Δ
unittests 49.75% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
syncapi/streams/stream_pdu.go 66.89% <0.00%> (-1.04%) ⬇️
userapi/internal/user_api.go 64.93% <0.00%> (ø)

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@S7evinK S7evinK merged commit 74a5ab6 into main Jul 7, 2023
16 of 18 checks passed
@S7evinK S7evinK deleted the s7evink/panic branch July 7, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants