Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh prosody dockerfile #1

Merged
merged 2 commits into from
Mar 12, 2021
Merged

Refresh prosody dockerfile #1

merged 2 commits into from
Mar 12, 2021

Conversation

benbz
Copy link

@benbz benbz commented Mar 11, 2021

This updates jitsi/docker-jitsi-meet@master...matrix-org:jaywink/prosody-image-http-module against a newer upstream base and minimises how much we need to build

@benbz
Copy link
Author

benbz commented Mar 11, 2021

@jaywink just to highlight that as part of this I have pushed master & tags from upstream to this repo

@benbz
Copy link
Author

benbz commented Mar 11, 2021

Separately I'm wondering if we want to put the prosody module(s) directly into this dockerfile and then build/host the image somewhere

@jaywink
Copy link
Member

jaywink commented Mar 12, 2021

Separately I'm wondering if we want to put the prosody module(s) directly into this dockerfile and then build/host the image somewhere

That would probably make sense 👍

Note though that the need for the http module might disappear, depending on how the Prosody module is made async. However, a custom docker image would still make sense to bundle everything together nicely.

@benbz
Copy link
Author

benbz commented Mar 12, 2021

I'd be strongly in favour of getting rid of the need for the http dependency, would allow us to simply extend the upstream image for Docker and less things to install for non-Docker.

@benbz benbz merged commit 47db720 into master Mar 12, 2021
@benbz benbz deleted the bbz/refresh-prosody-dockerfile branch March 12, 2021 08:23
@jaywink
Copy link
Member

jaywink commented Mar 12, 2021

I tried :P It was late at night. It crashed prosody. We need to find time to make something like that work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants