Avoid logging issues if we still could fetch keys #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #422 +/- ##
==========================================
+ Coverage 58.91% 58.99% +0.07%
==========================================
Files 51 51
Lines 7108 7113 +5
==========================================
+ Hits 4188 4196 +8
+ Misses 2531 2528 -3
Partials 389 389 ☔ View full report in Codecov by Sentry. |
kegsay
reviewed
Nov 22, 2023
| logger.WithFields(logrus.Fields{ | ||
| "servers": requestedServers, | ||
| "fetchers": len(k.KeyFetchers), | ||
| }).Warn("failed to fetch keys for some servers") |
There was a problem hiding this comment.
Without stating which servers this isn't very helpful.
There was a problem hiding this comment.
requestedServers is the list of the servers we failed to fetch keys for.
There was a problem hiding this comment.
Ah, that wasn't clear. LGTM then!
kegsay
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid confusion about e.g. being unable to fetch keys from matrix.org.