Fix event auth for knocking #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
==========================================
+ Coverage 59.80% 60.03% +0.23%
==========================================
Files 51 51
Lines 7137 7134 -3
==========================================
+ Hits 4268 4283 +15
+ Misses 2477 2458 -19
- Partials 392 393 +1 ☔ View full report in Codecov by Sentry. |
kegsay
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Seems really broken that we allow invite->knock transitions... Invites are more important than knocks as you can then transition to join from it, but you can't with knock.
The only time I guess it's useful is to revoke an invite of a knocked user, but I would have probably advocated for invite->leave and then make the knocker knock again, but oh well.
Codewise LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Knocking is not allowed in
restrictedrooms.