Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live location sharing - create m.beacon_info events #2238

Merged
merged 9 commits into from
Mar 15, 2022

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Mar 14, 2022

Create m.beacon_info.* events as per matrix-org/matrix-spec-proposals#3489

In this PR:

  • Send m.beacon_info.* state events.
  • track m.beacon_info.* events in room state

In next PRs:

  • produce good unique suffixes for beacon info events
  • geolocate and send m.beacon events for live beacons
  • maintain liveness state of beacons (checking for expiry, flipping isLive on event content)
  • expose and maintain 'user has live beacons' property

Here's what your changelog entry will look like:

✨ Features

Kerry Archibald added 7 commits March 14, 2022 16:07
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
@codecov-commenter
Copy link

Codecov Report

Merging #2238 (4686f78) into develop (57d71cc) will decrease coverage by 0.00%.
The diff coverage is 60.97%.

@@             Coverage Diff             @@
##           develop    #2238      +/-   ##
===========================================
- Coverage    57.89%   57.89%   -0.01%     
===========================================
  Files           91       92       +1     
  Lines        16308    16345      +37     
  Branches      3756     3764       +8     
===========================================
+ Hits          9442     9463      +21     
- Misses        6866     6882      +16     
Impacted Files Coverage Δ
src/@types/beacon.ts 100.00% <ø> (ø)
src/client.ts 34.94% <0.00%> (-0.06%) ⬇️
src/models/room-state.ts 72.42% <25.00%> (-1.30%) ⬇️
src/models/beacon.ts 70.00% <70.00%> (ø)
src/content-helpers.ts 77.77% <100.00%> (+2.77%) ⬆️

Kerry Archibald added 2 commits March 14, 2022 17:49
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
@kerryarchibald kerryarchibald marked this pull request as ready for review March 14, 2022 17:05
@kerryarchibald kerryarchibald requested a review from a team as a code owner March 14, 2022 17:05
@kerryarchibald kerryarchibald changed the title Psf 662/create beacon info Live location sharing - create m.beacon_info events Mar 14, 2022
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@kerryarchibald kerryarchibald merged commit c2fdb44 into develop Mar 15, 2022
@kerryarchibald kerryarchibald deleted the psf-662/create-beacon-info branch March 15, 2022 09:31
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request Apr 1, 2022
* emit aggregate room beacon liveness ([\matrix-org#2241](matrix-org#2241)).
* Live location sharing - create m.beacon_info events ([\matrix-org#2238](matrix-org#2238)).
* Beacon event types from MSC3489 ([\matrix-org#2230](matrix-org#2230)).
* Fix incorrect usage of unstable variant of `is_falling_back` ([\matrix-org#2227](matrix-org#2227)).
wx870601 added a commit to eachchat/matrix-js-sdk that referenced this pull request Apr 6, 2022
* emit aggregate room beacon liveness ([\matrix-org#2241](matrix-org#2241)).
* Live location sharing - create m.beacon_info events ([\matrix-org#2238](matrix-org#2238)).
* Beacon event types from MSC3489 ([\matrix-org#2230](matrix-org#2230)).
* Fix incorrect usage of unstable variant of `is_falling_back` ([\matrix-org#2227](matrix-org#2227)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants