This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Prep for matrix-js-sdk supporting intentional mentions #10431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
added
the
T-Task
t3chguy
approved these changes
Mar 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matrix-org/matrix-js-sdk#3092 currently fails the upstream checks during merge because the matrix-react-sdk has within it an embedded fake
MatrixClientobject. Some matrix-react-sdk tests fail (ondevelop) if you merge that PR since the fake client would no longer be compatible with the realMatrixClient.This gets around this issue by ripping part of #9983 into a separate PR which can be merged first, we can then merge matrix-org/matrix-js-sdk#3092; then we can merge #9983.
Checklist
Sign-off given on the changes (see CONTRIBUTING.md)This change is marked as an internal change (Task), so will not be included in the changelog.