This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Apply strictNullChecks to src/components/views/spaces/*
#10517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weeman1337
force-pushed
the
weeman1337/strictify-spaces-views
branch
from
542d81f
to
7ba2c54
Compare
weeman1337
added
the
T-Task
weeman1337
force-pushed
the
weeman1337/strictify-spaces-views
branch
from
7ba2c54
to
6766179
Compare
alunturner
reviewed
Apr 11, 2023
weeman1337
force-pushed
the
weeman1337/strictify-spaces-views
branch
from
27010c3
to
26cfa37
Compare
|
@weeman1337 test failures look legit |
weeman1337
force-pushed
the
weeman1337/strictify-spaces-views
branch
from
fb6eadf
to
3ee5c14
Compare
weeman1337
changed the title
src/components/views/spaces/*strictNullChecks to src/components/views/spaces/*
weeman1337
force-pushed
the
weeman1337/strictify-spaces-views
branch
from
3ee5c14
to
f6eb04f
Compare
alunturner
approved these changes
Apr 18, 2023
|
Approved with the assumption that the TS error in the |
alunturner
reviewed
May 17, 2023
| @@ -95,9 +95,9 @@ export const SpaceButton = forwardRef<HTMLElement, IButtonProps>( | |||
| } | |||
|
|
|||
| let notifBadge; | |||
| if (notificationState) { | |||
| if (space && notificationState) { | |||
There was a problem hiding this comment.
Not sure if this interests you, but there's now a Typeguards.ts file that has an isNotUndefined helper typeguard for situations like this.
t3chguy
reviewed
Jun 28, 2023
src/settings/Settings.tsx
Outdated
| @@ -662,7 +662,7 @@ export const SETTINGS: { [setting: string]: ISetting } = { | |||
| }, | |||
| "custom_themes": { | |||
| supportedLevels: LEVELS_ACCOUNT_SETTINGS, | |||
| default: [], | |||
| default: false, | |||
There was a problem hiding this comment.
Suggested change
| default: false, | |
| default: [] as ICustomTheme[], |
and export ICustomTheme from theme.ts and add its name: string field which seems to be missing
t3chguy
reviewed
Jun 28, 2023
t3chguy
approved these changes
Jun 28, 2023
|
Thanks!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes element-hq/element-web#24942
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.