Add E2E test for LabsUserSettingsTab
#10736
Conversation
github-actions
bot
added
Z-Community-PR
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
| }); | ||
|
|
||
| it("should be rendered properly", () => { | ||
| cy.get(".mx_SettingsTab.mx_LabsUserSettingsTab").percySnapshotElement("User settings tab - Labs", { |
There was a problem hiding this comment.
I'm not sure this is a good candidate for a percy snapshot, or an e2e test at all, as the labs screen is intended to change regularly
There was a problem hiding this comment.
Regularly but not daily, right? I believe that taking a whole snapshot would help to prevent a case like element-hq/element-web#24813. Please let me know if a Jest snapshot would be sufficient here.
There was a problem hiding this comment.
@andybalaam I would like to ask your opinion on that too. Thanks in advance.
There was a problem hiding this comment.
In my opinion a jest test is more suitable for this case - where we can use stable mock data that covers all the cases. Then we can be sure that the case from 24813 will be covered and continue to be covered, independent of what features are in labs at that time.
There was a problem hiding this comment.
Yeah, I agree that a Jest test would probably be the best fit here. We have to review each Percy failure manually, so we should definitely not create tests that we expect to fail regularly.
Thanks for the work @luixxiul !
There was a problem hiding this comment.
Thanks both of you for opinions! Now I am convinced.
Close element-hq/element-web#25228
type: task
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.