Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix read receipt animation #12923

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Fix read receipt animation #12923

merged 3 commits into from
Sep 3, 2024

Commits on Aug 23, 2024

  1. Fix read receipt animation 

    The way it was done involved remembering dom nodes and then getting
their position later when animating the receipt to its next position,
but I'm not sure how this worked since the DOM node may not neccessarily
be in the DOM anymore. Instead, just remember the bounding box coordinates.
At worst it might go weird if the window is resized but seems fine in
practice. Also, keeping references to dom nodes feels like a fast road
to memory leaks.

Fixes element-hq/element-web#27916
    @dbkr
    dbkr committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    93c4d6d View commit details
    Browse the repository at this point in the history

  2. Attempt to write a test for read receipts 

    and fix naming
    @dbkr
    dbkr committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    3217602 View commit details
    Browse the repository at this point in the history

  3. Another test 

    also change a condition to make it testable
    @dbkr
    dbkr committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    89b04af View commit details
    Browse the repository at this point in the history