This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
kill stream when using gUM for permission to device labels to turn off camera #1931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mera Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
| _refreshMediaDevices: function() { | ||
| _refreshMediaDevices: function(stream) { | ||
| if (stream) { | ||
| // kill stream so that we don't leave it lingering around with webcam enabled etc |
There was a problem hiding this comment.
Perhaps also explain that we don't need streams now, we just need device IDs to populate the audio and video input dropdowns.
lukebarnard1
approved these changes
May 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#6530
Signed-off-by: Michael Telatynski 7t3chguy@gmail.com