This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Show "Incompatible store" dialog when IDB version is too high #2199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way the logic to switch between indexeddb/memory store can be made higher up (in Lifecycle) depending on the error (e.g. VersionError) and user input (a dialog) Also merged replaceUsingCreds and start as they are always called together and one should not be called without the other.
Move LL toggling code to this method as well
instead of just clearing the store without saying anything this will create less confusion when using /app and /develop
undoing previous changes, as falling back to another store after an error during MatrixClient::startClient results in an infinite spinner and we don't want to spend more time on this.
bwindels
changed the title
|
Going to abandon this, as trying it out is now also infinispinnering, and don't want to spend more time on a problem we currently don't have. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses element-hq/element-web#7432