This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Move initial key backup to background #2416
Merged
Commits on Jan 9, 2019
-
-
-
Mark KeyBackupPanel as a pure component
KeyBackupPanel depends only on its own state and its children are pure, so it can be pure as well. This avoids some unnecessary re-renders.
-
Display key backup upload progress in Settings
This adds a summary of the keys currently waiting for backup, which may be useful for following a large upload as it progresses.
-
Move initial key backup to background
Since the initial key backup can take several minutes for some users, this moves the upload step to the background. The create key backup flow now only marks all sessions for backup synchronously, with the actual backup happening later. The key backup panel in Settings gains a new row to show a summary of upload status. Users are directed there if they wish to know if the backup is done. The text in various related dialogs has also been tweaked to fit the new flow.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.