This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Allow configuration of whether closing window closes or minimizes to tray #2688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tray Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
|
Depends on element-hq/element-web#8908 |
turt2live
suggested changes
Feb 25, 2019
| @@ -113,4 +113,29 @@ export default class BasePlatform { | |||
| reload() { | |||
| throw new Error("reload not implemented!"); | |||
| } | |||
|
|
|||
| supportsAutoLaunch(): boolean { | |||
There was a problem hiding this comment.
we don't have type annotations anywhere else. We probably should have them, but for now I'd say don't include them as it introduces confusion.
There was a problem hiding this comment.
nvm, it is worse than that: we do use it in the scope of electron. I'm not going to block this PR on that :/
turt2live
approved these changes
Feb 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also moves the Autolaunch platform stuff into the BasePlatform otherwise Preferences Settings would crash given a non-VectorBasePlatform Platform.
Signed-off-by: Michael Telatynski 7t3chguy@gmail.com