This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Get confirmation before enabling encryption #2728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
force-pushed
the
travis/encryption-warning
branch
from
21fc480
to
9402e81
Compare
uhoreg
reviewed
Mar 1, 2019
src/components/views/settings/tabs/room/SecurityRoomSettingsTab.js
Outdated
Show resolved
Hide resolved
t3chguy
reviewed
Mar 1, 2019
| ), | ||
| onFinished: (confirm) => { | ||
| if (!confirm) { | ||
| this.setState({encrypted: false}); |
There was a problem hiding this comment.
All looks good but I'm getting hung up on this, the code later tries to revert to the original state yet this just blindly says false, I don't see why we need a setState here at all though?
There was a problem hiding this comment.
Because the toggle is partially controlled and animates as enabling. It's a feature of the toggle, so we have to counteract it. It also gives a visual cue that the toggle is in fact disabled.
turt2live
requested review from
t3chguy and
a team
and removed request for
t3chguy
jryans
approved these changes
Mar 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#8843
Well paired with #2724