This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Copy events from the timeline in an IRC log style format #3370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is this actually happening for you today? We've tried to prevent this somewhat by setting Aha, after some testing, it appears Firefox does listen to this CSS when copying, but Chrome does not. 😕 |
|
Testing, it seems the behaviour here is sensible now so I think this PR is no longer necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than as incoherent gunks of HTML and text, which ends up including avatars and RRs and context menus and all sorts.
It's debatable as to whether this is the right approach: we go and walk the displayed DOM, putting the innerHTML/innerText of the event contents into a new wrapper built from the event's metadata.
Instead, we could make EventTile support rendering to a logger mode, which would then help us finally fix element-hq/element-web#2630. However, this means that we would be completely rebuilding the clipboard rather than basing it on what the user actually copied (and for instance, it would be much harder to handle partial event selections).
This solution could always evolve in that direction in future though.
thoughts welcome.