Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Change a bunch of strings from Recovery Key/Phrase to Security Key/Phrase #5533

Merged
merged 3 commits into from
Jan 21, 2021

Conversation

aaronraimist
Copy link
Contributor

@aaronraimist aaronraimist commented Jan 5, 2021

Fixes element-hq/element-web#15500

Improves element-hq/element-meta#1474


This PR currently has none of the required changelog labels.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

…rase

Signed-off-by: Aaron Raimist <aaron@raim.ist>
@jryans jryans requested a review from a team January 11, 2021 17:47
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this clean up, overall it looks great! Just a few further tweaks, and then it should be ready to merge.

aaronraimist and others added 2 commits January 12, 2021 16:04
Co-authored-by: J. Ryan Stinnett <jryans@gmail.com>
Signed-off-by: Aaron Raimist <aaron@raim.ist>
@aaronraimist
Copy link
Contributor Author

Okay that is fixed

@jryans
Copy link
Collaborator

jryans commented Jan 21, 2021

Okay that is fixed

Thanks, sorry for the delay, I am quite behind on notifications. Re-requesting review like you just did is the best way for me to see it promptly. 😄

Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for working on this, I think it will help comprehension quite a lot! 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Security Key" wording is confusing when it really wants the recovery key
2 participants