Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Show space members when not invited even if summary didn't fail #7153

Merged
merged 2 commits into from
Nov 19, 2021
Merged

Show space members when not invited even if summary didn't fail #7153

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a69b810
Show space members when not invited even if summary didn't fail
t3chguy Nov 17, 2021
3d69ad7
add comments
t3chguy Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/structures/SpaceRoomView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ const useMyRoomMembership = (room: Room) => {
};

const SpaceInfo = ({ space }: { space: Room }) => {
// summary will begin as undefined whilst loading and go null if it fails to load.
const summary = useAsyncMemo(async () => {
if (space.getMyMembership() !== "invite") return;
try {
Expand Down Expand Up @@ -156,7 +157,7 @@ const SpaceInfo = ({ space }: { space: Room }) => {
memberSection = <span className="mx_SpaceRoomView_info_memberCount">
{ _t("%(count)s members", { count: summary.num_joined_members }) }
</span>;
} else if (summary === null) {
} else if (summary !== undefined) { // summary is not still loading
memberSection = <RoomMemberCount room={space}>
{ (count) => count > 0 ? (
<AccessibleButton
Expand Down