Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Display and send votes in polls #7158

Merged
merged 10 commits into from
Nov 23, 2021

Conversation

andybalaam
Copy link
Contributor

@andybalaam andybalaam commented Nov 18, 2021

This is the first draft of votes being sent and displayed in polls.

image

Later pull requests will fix some issues:

  • a limit on the number of characters in questions in answers
  • overlap of option text with the vote count in some screen sizes
  • error messages and waiting spinners when actions are happening

This change is marked as an internal change (Task), so will not be included in the changelog.

Preview: https://6197752cb934fbbc06eaaa12--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@andybalaam andybalaam requested a review from a team as a code owner November 18, 2021 14:37
@SimonBrandner SimonBrandner added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Nov 18, 2021
@andybalaam andybalaam added T-Task Refactoring, enabling or disabling functionality, other engineering tasks and removed T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements labels Nov 18, 2021
@andybalaam
Copy link
Contributor Author

@SimonBrandner we're labelling polls stuff as T-Task for now, so it doesn't appear in the release notes until it's ready to use.

@SimonBrandner
Copy link
Contributor

@SimonBrandner we're labelling polls stuff as T-Task for now, so it doesn't appear in the release notes until it's ready to use.

Ah, sorry for misusing the label, thanks for letting me know

@andybalaam
Copy link
Contributor Author

Ah, sorry for misusing the label, thanks for letting me know

Actually I think it's probably me misusing the labels, but I guess not calling it a feature when it's hidden behind a labs flag is sort-of legit.

@Half-Shot
Copy link
Contributor

I wholeheartedly disagree with the verdict of this poll, but it's a lovely render!

@andybalaam
Copy link
Contributor Author

I wholeheartedly disagree with the verdict of this poll, but it's a lovely render!

I actually had to re-do the screenshot because I accidentally got the wrong answer first time.

Copy link

@gaelledel gaelledel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brill :)

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine - just a few human linter things that we really should put into the lint rules.

src/components/views/messages/MPollBody.tsx Outdated Show resolved Hide resolved
src/components/views/messages/MPollBody.tsx Outdated Show resolved Hide resolved
src/components/views/messages/MPollBody.tsx Outdated Show resolved Hide resolved
src/components/views/messages/MPollBody.tsx Outdated Show resolved Hide resolved
src/components/views/messages/MPollBody.tsx Outdated Show resolved Hide resolved
src/components/views/messages/MPollBody.tsx Outdated Show resolved Hide resolved
src/components/views/messages/MPollBody.tsx Outdated Show resolved Hide resolved
andybalaam and others added 6 commits November 19, 2021 09:30
Co-authored-by: Travis Ralston <travpc@gmail.com>
Co-authored-by: Travis Ralston <travpc@gmail.com>
Co-authored-by: Travis Ralston <travpc@gmail.com>
Co-authored-by: Travis Ralston <travpc@gmail.com>
Co-authored-by: Travis Ralston <travpc@gmail.com>
@andybalaam
Copy link
Contributor Author

I have completed all the requested changes, thanks.

@andybalaam
Copy link
Contributor Author

@turt2live this is ready for you to re-review.

@turt2live turt2live self-requested a review November 22, 2021 14:00
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andybalaam andybalaam merged commit d705fdd into matrix-org:develop Nov 23, 2021
@andybalaam andybalaam deleted the psf-331-register-a-vote branch November 23, 2021 10:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants