Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Ensure my votes from a different device show up #7233

Conversation

andybalaam
Copy link
Contributor

@andybalaam andybalaam commented Nov 30, 2021

After this change:
voting-on-other-devices

(Before this change):
voting-on-other-devices-before


This change is marked as an internal change (Task), so will not be included in the changelog.

Preview: https://61a8fd8a704d8b3bd508732e--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@andybalaam andybalaam added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Nov 30, 2021
@andybalaam andybalaam requested a review from a team as a code owner November 30, 2021 14:38
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm - mostly just future proofing with the undocumented UnstableValue class (sorry, this is my fault).

src/components/views/messages/MPollBody.tsx Outdated Show resolved Hide resolved
src/components/views/messages/MPollBody.tsx Outdated Show resolved Hide resolved
test/components/views/messages/MPollBody-test.tsx Outdated Show resolved Hide resolved
src/components/views/messages/MPollBody.tsx Outdated Show resolved Hide resolved
andybalaam and others added 4 commits December 2, 2021 09:56
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm - thanks!

src/components/views/messages/MPollBody.tsx Outdated Show resolved Hide resolved
Co-authored-by: Travis Ralston <travpc@gmail.com>
@andybalaam andybalaam enabled auto-merge (squash) December 2, 2021 17:05
@andybalaam andybalaam merged commit 141950d into matrix-org:develop Dec 2, 2021
@andybalaam andybalaam deleted the psf-557-override-selection-with-new-event branch December 2, 2021 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants