Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Refactor matrix-linkify module #7279

Merged
merged 12 commits into from
Dec 3, 2021
Merged

Refactor matrix-linkify module #7279

merged 12 commits into from
Dec 3, 2021

Conversation

Palid
Copy link
Contributor

@Palid Palid commented Dec 3, 2021

Refactor the module to make it easier for upgrade and proper separation of code contexts


This change is marked as an internal change (Task), so will not be included in the changelog.

Preview: https://61aa2292ec7b1a4a0f064fea--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

Refactor the module to make it easier for upgrade and proper separation
of code contexts
@Palid Palid requested a review from a team as a code owner December 3, 2021 13:14
@Palid Palid added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Dec 3, 2021
src/linkify-matrix.ts Outdated Show resolved Hide resolved
src/linkify-matrix.ts Outdated Show resolved Hide resolved
src/linkify-matrix.ts Outdated Show resolved Hide resolved
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@Palid Palid requested a review from t3chguy December 3, 2021 13:41
src/linkify-matrix.ts Outdated Show resolved Hide resolved
test/Markdown-test.ts Outdated Show resolved Hide resolved
@Palid Palid enabled auto-merge (squash) December 3, 2021 13:58
@Palid Palid merged commit 961fec9 into develop Dec 3, 2021
@Palid Palid deleted the palid/refactor-linkify branch December 3, 2021 14:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants