Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Enable the live location share button #8056

Merged
merged 11 commits into from
Mar 16, 2022

Conversation

andybalaam
Copy link
Contributor

@andybalaam andybalaam commented Mar 15, 2022


This change is marked as an internal change (Task), so will not be included in the changelog.

Preview: https://pr8056--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@andybalaam andybalaam added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Mar 15, 2022
@andybalaam andybalaam requested a review from a team as a code owner March 15, 2022 10:23
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #8056 (98f4175) into develop (e1fdff4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #8056   +/-   ##
========================================
  Coverage    26.82%   26.82%           
========================================
  Files          866      866           
  Lines        51941    51941           
  Branches     13160    13160           
========================================
  Hits         13934    13934           
  Misses       38007    38007           
Impacted Files Coverage Δ
src/components/views/location/ShareType.tsx 100.00% <ø> (ø)

Copy link
Contributor

@kerryarchibald kerryarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good apart from conflicts

@andybalaam andybalaam enabled auto-merge (squash) March 16, 2022 09:30
@andybalaam andybalaam merged commit cbf5fbf into develop Mar 16, 2022
@andybalaam andybalaam deleted the psf-771-enable-live-share-button branch March 16, 2022 09:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants