This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix scroll behaviour in space panel #8109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Annoyingly this increases complexity of an already-complex LoggedInView, however the flex layout in the left panel doesn't allow for us to easily add a rowspan-like element such as the live location share warning. To circumvent this for purposes of release, we'll just chuck the live location sharing warning functionality into LoggedInView, which can manage a set of CSS classes to mimic a rowspan across the top of the room list. Trying to make the left panel a nested flexbox works visually, but breaks all the scroll behaviour for the room list and space panel. This is likely because the flexbox layout of the left panel is already trying to do too many tricks to get the layout to work just right, so adding a fifteenth trick by nesting the flexboxes just doesn't work. It's unclear which trick specifically is breaking the scroll behaviour. It's absolutely awful, but it works.
turt2live
added
X-Release-Blocker
This was referenced Mar 22, 2022
Codecov Report
@@ Coverage Diff @@
## develop #8109 +/- ##
===========================================
- Coverage 27.19% 27.17% -0.02%
===========================================
Files 872 871 -1
Lines 52207 52208 +1
Branches 13231 13233 +2
===========================================
- Hits 14197 14189 -8
- Misses 38010 38019 +9
|
|
Closing in favour of #8111 which is a much more reasonable fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#21467 (but we should revisit the fix)
Regressed by #8066
Annoyingly this increases complexity of an already-complex LoggedInView, however the flex layout in the left panel doesn't allow for us to easily add a rowspan-like element such as the live location share warning.
To circumvent this for purposes of release, we'll just chuck the live location sharing warning functionality into LoggedInView, which can manage a set of CSS classes to mimic a rowspan across the top of the room list.
Trying to make the left panel a nested flexbox works visually, but breaks all the scroll behaviour for the room list and space panel. This is likely because the flexbox layout of the left panel is already trying to do too many tricks to get the layout to work just right, so adding a fifteenth trick by nesting the flexboxes just doesn't work. It's unclear which trick specifically is breaking the scroll behaviour.
It's absolutely awful, but it works.
Here's what your changelog entry will look like:
🐛 Bug Fixes
Preview: https://pr8109--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.