Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix incorrect visibility (public/private) being assumed when creating a room #8827

Closed
wants to merge 1 commit into from
Closed

Fix incorrect visibility (public/private) being assumed when creating a room #8827

wants to merge 1 commit into from

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Jun 12, 2022 •
edited by github-actions bot
Loading

Fixes element-hq/element-web#22578

Here's what your changelog entry will look like:

🐛 Bug Fixes

@SimonBrandner
Fix incorrect visibility being assumed when creating a room
0e070ea 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner SimonBrandner added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Jun 12, 2022
@SimonBrandner SimonBrandner requested a review from a team as a code owner June 12, 2022 17:23
turt2live
turt2live suggested changes Jun 13, 2022
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be accompanied by an issue or bug description, as it's not clear what code would be triggering this and thus whether the fix is valid for the case at hand.

@SimonBrandner
Copy link
Contributor Author

This should be accompanied by an issue or bug description, as it's not clear what code would be triggering this and thus whether the fix is valid for the case at hand.

Sorry about that... An issue is linked now: element-hq/element-web#22578

turt2live
turt2live approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise lgtm, however per the issue this effectively needs a product decision to happen.

@turt2live turt2live requested a review from a team June 14, 2022 21:57
@SimonBrandner
Copy link
Contributor Author

Ok, after discussing in element-hq/element-web#22578, let's move this behind a server flag

@SimonBrandner SimonBrandner deleted the SimonBrandner/fix/space-vis branch June 15, 2022 12:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When creating a public space, server receives visibility: private
2 participants
@SimonBrandner @turt2live