Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Set 100% max-width to display name on reply tiles #8867

Merged
merged 2 commits into from
Jun 20, 2022
Merged

Set 100% max-width to display name on reply tiles #8867

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0be0f1a
Set 100% max-width to display name on reply tiles
luixxiul Jun 18, 2022
2a96650
Merge branch 'develop' into DisambiguatedProfile
luixxiul Jun 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions res/css/views/rooms/_EventBubbleTile.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ limitations under the License.

.mx_ReplyTile .mx_DisambiguatedProfile {
display: block;
max-width: 100%;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before After
before after

}

.mx_ReactionsRow {
Expand Down
2 changes: 1 addition & 1 deletion res/css/views/rooms/_EventTile.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ $threadInfoLineHeight: calc(2 * $font-12px); // See: _commons.scss
> .mx_DisambiguatedProfile {
line-height: $font-20px;
margin-left: $left-gutter;
max-width: calc(100% - $left-gutter);
Copy link
Contributor Author

@luixxiul luixxiul Jun 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

synchronized with the margin-left declaration just above.

This relationship became clear thanks to deprecating mx_GroupLayout with a recent PR 😄

}

> .mx_EventTile_avatar {
Expand Down Expand Up @@ -152,7 +153,6 @@ $threadInfoLineHeight: calc(2 * $font-12px); // See: _commons.scss
display: inline-block;
padding-bottom: 0px;
padding-top: 0px;
max-width: calc(100% - $left-gutter);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before After
before2 after2

Because max-width: calc(100% - $left-gutter) is no longer applied to mx_DisambiguatedProfile inside reply tiles.

}

&.mx_EventTile_isEditing .mx_MessageTimestamp {
Expand Down
1 change: 0 additions & 1 deletion res/css/views/rooms/_IRCLayout.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,6 @@ $irc-line-height: $font-18px;
margin: 0;
.mx_DisambiguatedProfile {
order: unset;
max-width: unset;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before After
before1 after1

width: unset;
background: transparent;
}
Expand Down