-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking issue for timeline API #1103
Comments
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
I'm not editing the issue since I'm not sure if this is the best place to ask for this (sorry if it's not!). Could we add an item for toggling user reactions in an event? Sending a reaction is simple, but we also need to handle:
|
Soo I'm leaving Element and there's still a lot to do here. Here's my attempt to write down my thoughts on the remaining tasks w.r.t the timeline API:
|
An extra note: fetching the entire timeline, on disk, at least once, would be necessary for indexing in the case of full-text search. This would also help with perfectly computing read receipts, as the last known read receipt may live on a very old event, and we'd need all the events between the old event and the latest ones to properly compute the number of unread messages as well as highlights/notifications. It might also imply that we maintain all timelines alive, and keep only a handful of events in memory for those not active (not in the foreground), so we can update them accordingly. |
I think this issue has served its time. If there are new feature requirements or bug fixes related to the timeline, please open new issues :-) |
Now that the initial PR is merged, here is an incomplete list of things we don't have yet in the timeline API, that we need to implement before calling it complete, in no particular order:
EncryptionInfo
, I think)LocalEventTimelineItem
has a newsend_state
field #1419 — An error state for local echo items that failed to sendThe text was updated successfully, but these errors were encountered: