Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): Add day dividers to the experimental timeline #1251

Merged
merged 5 commits into from
Dec 14, 2022

Conversation

zecakeh
Copy link
Collaborator

@zecakeh zecakeh commented Dec 1, 2022

Tested locally in Fractal.

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Base: 74.21% // Head: 74.18% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (7c60493) compared to base (ee713d4).
Patch coverage: 68.42% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1251      +/-   ##
==========================================
- Coverage   74.21%   74.18%   -0.04%     
==========================================
  Files         114      115       +1     
  Lines       13006    13060      +54     
==========================================
+ Hits         9653     9689      +36     
- Misses       3353     3371      +18     
Impacted Files Coverage Δ
...ates/matrix-sdk/src/room/timeline/event_handler.rs 70.47% <67.85%> (-1.08%) ⬇️
...rates/matrix-sdk/src/room/timeline/virtual_item.rs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jplatte jplatte mentioned this pull request Dec 5, 2022
29 tasks
For a local event, that's the timestamp when the event was created.
For an event returned by the server, it's the origin server timestamp.
Copy link
Collaborator

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just a few small questions and suggestions.

@jplatte jplatte enabled auto-merge (squash) December 14, 2022 11:08
@jplatte jplatte merged commit 37bea19 into matrix-org:main Dec 14, 2022
@zecakeh zecakeh deleted the timeline-day-divider branch December 14, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants