Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Create a new normalized_match_room_name filter #2428

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

Hywan
Copy link
Member

@Hywan Hywan commented Aug 21, 2023

This patch adds a new filter for room list's entries. We had all and fuzzy_match_room_name, now this patch adds normalized_match_room_name. Both the pattern and the subject are normalized and lowercased, and then it's an exact match: subject.contains(pattern).

This patch creates a new `normalized_match_room_name` filter for
`RoomListService`.
@Hywan Hywan requested a review from a team as a code owner August 21, 2023 08:24
@Hywan Hywan requested review from jplatte and removed request for a team August 21, 2023 08:24
@Hywan Hywan changed the title feat(ui): Crate a new normalized_match_room_name filter feat(ui): Create a new normalized_match_room_name filter Aug 21, 2023
@Hywan Hywan requested review from bnjbvr and removed request for jplatte August 21, 2023 09:10
Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@Hywan Hywan merged commit 64f3bc6 into matrix-org:main Aug 21, 2023
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants