feat(sdk): Remove SlidingSyncRoomInner::inner
#3085
Conversation
This patch removes the need to store and to update the `SlidingSyncRoom::inner` field (of type `v4::SlidingSyncRoom`). Now, we just need to handle the `prev_batch`, which is the only data we care about. Bonus: it reduces the size of the frozen sliding sync room quite much.
Hywan
force-pushed
the
fix-sdk-sliding-sync-room-inner
branch
from
02c879a
to
43bed28
Compare
Hywan
requested review from
bnjbvr,
poljar and
a team
and removed request for
a team and
bnjbvr
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3085 +/- ##
==========================================
+ Coverage 83.71% 83.72% +0.01%
==========================================
Files 224 224
Lines 23497 23478 -19
==========================================
- Hits 19671 19658 -13
+ Misses 3826 3820 -6 ☔ View full report in Codecov by Sentry. |
| /// Internal state of `Self`. | ||
| state: RwLock<SlidingSyncRoomState>, | ||
|
|
||
| /// The token for back-pagination. | ||
| prev_batch: RwLock<Option<String>>, |
There was a problem hiding this comment.
There's actually a field in RoomInfo for this as well:
matrix-rust-sdk/crates/matrix-sdk-base/src/rooms/normal.rs
Lines 777 to 778 in ff89315
If the field in RoomInfo makes sense is debatable, but I did want to let you know about it.
There was a problem hiding this comment.
Hmm interesting. I'll update this PR to use the Roominfo::last_prev_batch field instead. It seems more relevant. Thanks!
There was a problem hiding this comment.
Feel free to move this to a separate PR, there has been talk that this should not be part of the RoomInfo, though I can't remember the specific complaint anymore.
This patch removes the need to store and to update the
SlidingSyncRoom::innerfield (of typev4::SlidingSyncRoom). Now,we just need to handle the
prev_batch, which is the only data we careabout.
Bonus: it reduces the size of the frozen sliding sync room quite much.
SlidingSyncRoomtech debt #3079