event ~~~graph~~~ cache: listen to the updates to all rooms at once #3122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3122 +/- ##
==========================================
- Coverage 83.85% 83.82% -0.03%
==========================================
Files 229 230 +1
Lines 23706 23725 +19
==========================================
+ Hits 19879 19888 +9
- Misses 3827 3837 +10 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Feb 15, 2024
| @@ -291,6 +297,7 @@ impl ClientInner { | |||
| event_handlers: Default::default(), | |||
| notification_handlers: Default::default(), | |||
| room_update_channels: Default::default(), | |||
| room_updates_sender: broadcast::Sender::new(32), | |||
There was a problem hiding this comment.
Can we add a comment why we think this value for the capacity is OK? This does mean up to 32 RoomUpdates will be buffered and max one RoomUpdate will be created per sync?
(instead of having to subscribe to a single room in the event cache)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See changes commit by commit. Sitting on top of #3121.
Part of #3058.