Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC3012: Post-registration terms of service API #3012

Open
wants to merge 1 commit into
base: old_master
Choose a base branch
from
Open

MSC3012: Post-registration terms of service API #3012

wants to merge 1 commit into from

Conversation

turt2live
Copy link
Member

@turt2live turt2live added client-server Client-Server API kind:core MSC which is critical to the protocol's success proposal A matrix spec change proposal proposal-in-review labels Feb 17, 2021
@turt2live turt2live mentioned this pull request Feb 17, 2021
Merged
Sorunome
Sorunome reviewed Feb 18, 2021
View reviewed changes
proposals/3012-tos-api.md
6. The homeserver logs the user in by generating a token and returning it to the client as per
the specification.

This process is chosen to begin introducing the UI auth mechanism to login without breaking clients.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2835 switches to full UIA directly and does not break login with existing clients. Special-casing terms seems unneeded?

@turt2live turt2live added the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Jun 8, 2021
turt2live
turt2live commented Dec 8, 2021
View reviewed changes
proposals/3012-tos-api.md
In addition, the homeserver should not prevent the use of the special "terms acceptance" API
described in the next section.

### Terms acceptance API
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should also be an (unauthenticated) endpoint to get the current terms, mirroring the identity server approach. Optional authentication for scoping.

@bmarty bmarty mentioned this pull request Dec 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sorunome Sorunome Sorunome left review comments

Assignees
No one assigned
Labels
client-server Client-Server API kind:core MSC which is critical to the protocol's success needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turt2live @Sorunome