Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC3266: Room summary API #3266

Open
wants to merge 27 commits into
base: old_master
Choose a base branch
from
Open
Changes from 2 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
642f4e1
Room summary proposal
deepbluev7 Jul 4, 2021
188b6e5
Remove alias resolution step from the federation API
deepbluev7 Jul 5, 2021
dc5b372
Reference #688 in the alternatives section
deepbluev7 Jul 12, 2021
975ece5
Remove `is_direct` from response
deepbluev7 Jul 14, 2021
d148acf
Fix unstable prefixes for implementations which keep the prefix and r…
deepbluev7 Jul 14, 2021
6776863
Add allowed_room_ids field
deepbluev7 Jul 14, 2021
df376a3
Extend rationale for additional fields to reference MSC2946
deepbluev7 Jul 14, 2021
43eecf0
Add bulk API as an alternative
deepbluev7 Jul 14, 2021
66fee23
Remove federation API and address feedback
deepbluev7 Oct 6, 2021
469b77b
fix prefixes again
deepbluev7 Oct 20, 2021
04f807b
Remove extensions to federation API since that MSC is amended now
deepbluev7 Oct 20, 2021
f1233c4
Fix minor inaccuracy about the spaces sumary api
deepbluev7 Dec 3, 2021
5fc2f5b
Add encryption field back
deepbluev7 May 2, 2022
9e41b45
Add room version field
deepbluev7 May 2, 2022
cab37e5
Apply suggestions from code review
deepbluev7 May 2, 2022
a93190f
Add a bit more reasoning
deepbluev7 May 2, 2022
8186b72
version -> room_version
deepbluev7 May 4, 2022
1a8ecff
Apply suggestions from code review
deepbluev7 Jul 19, 2022
82d8f3b
Try to address review comments
deepbluev7 Jul 19, 2022
208a58c
Fix incorrect statement about encryption being a bool
deepbluev7 Jul 24, 2022
33f3733
Apply suggestions from code review
deepbluev7 Jul 26, 2022
a5bc9ef
Split up the big alternatives section
deepbluev7 Jul 26, 2022
ac3d5da
Collapse the same descriptions for publicRooms and hierarchy into one
deepbluev7 Jul 26, 2022
dba6705
Shorten the 'accessible' section again
deepbluev7 Jul 26, 2022
9719119
Update proposals/3266-room-summary.md
deepbluev7 Aug 1, 2022
2ad832c
Update proposals/3266-room-summary.md
deepbluev7 Dec 14, 2022
81fd904
Update proposals/3266-room-summary.md
deepbluev7 Dec 31, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
165 changes: 165 additions & 0 deletions proposals/3266-room-summary.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,165 @@
# MSC3266: Room Summary API
KitsuneRal marked this conversation as resolved.
Show resolved Hide resolved

deepbluev7 marked this conversation as resolved.
Show resolved Hide resolved
Quite a few clients and tools have a need preview a room:

- A client may want to show the room in the roomlist, when showing a space.
- matrix.to may want to show avatar and name of a room.
- Nextcloud may want to list the names and avatars of your `/joined_rooms` when
deepbluev7 marked this conversation as resolved.
Show resolved Hide resolved
asking where to share the media.
- A client may want to preview a room, when hovering a room alias, id or after
clicking on it.
- A client may want to preview a room, when the user is trying to knock on it or
to show pending knocks.
- A traveller bot may use that to show a room summary on demand without actually
keeping the whole room state around and having to subscribe to /sync (or
using the appservice API).

There are a few ways to request a room summary, but they only support some of
the use cases. The spaces summary API
([MSC2946](https://github.com/matrix-org/matrix-doc/pull/2946)) only provides
deepbluev7 marked this conversation as resolved.
Show resolved Hide resolved
limited control over what rooms to summarize and only works for rooms in spaces.
`{roomid}/initialSync` and `{roomid}/state/{event_type}` don't work over
federation and are much heavier than necessary or need a lot of http calls for
each room.

## Proposal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We appear to be missing error conditions from the MSC: what if the room doesn't exist? is invalid? unroutable?


A new client-server API, which allows you to fetch a summary of a room by id or
alias and a corresponding server-server API, to fetch a summary over federation.
deepbluev7 marked this conversation as resolved.
Show resolved Hide resolved

### Client-Server API

The API returns the summary of the specified room, if the room could be found
and the client should be able to view its contents according to the join_rules,
history visibility, space membership and similar rules outlined in
deepbluev7 marked this conversation as resolved.
Show resolved Hide resolved
[MSC3173](https://github.com/matrix-org/matrix-doc/pull/3173) as well as if the
user is already a member of that room.
richvdh marked this conversation as resolved.
Show resolved Hide resolved

A request could look like this:

```
GET /_matrix/client/r0/rooms/{roomidOrAlias}/summary?
deepbluev7 marked this conversation as resolved.
Show resolved Hide resolved
via=matrix.org&
via=neko.dev
```

- `roomidOrAlias` can be the roomid or an alias to a room.
deepbluev7 marked this conversation as resolved.
Show resolved Hide resolved
- `via` are servers, that should be tried to request a summary from, if it can't
deepbluev7 marked this conversation as resolved.
Show resolved Hide resolved
be generated locally. These can be from a matrix URI, matrix.to link or a
`m.space.child` event for example.

A response includes the stripped state in the following format:

```json5
{
room_id: "!ol19s:bleecker.street",
avatar_url: "mxc://bleecker.street/CHEDDARandBRIE",
guest_can_join: false,
name: "CHEESE",
num_joined_members: 37,
topic: "Tasty tasty cheese",
world_readable: true,
join_rules: "public",
richvdh marked this conversation as resolved.
Show resolved Hide resolved
room_type: "m.space",
is_direct: true,
membership: "invite",
is_encrypted: true,
}
```

These are the same fields as those returned by `/publicRooms`, with a few
additions: `room_type`, `is_direct`, `membership` and `is_encrypted`.

All those fields are already accessible as the stripped state according to
deepbluev7 marked this conversation as resolved.
Show resolved Hide resolved
[MSC3173](https://github.com/matrix-org/matrix-doc/pull/3173), with the
deepbluev7 marked this conversation as resolved.
Show resolved Hide resolved
exception of `membership` and potentially `is_direct`.

#### Rationale and description of reponse fields
deepbluev7 marked this conversation as resolved.
Show resolved Hide resolved

| fieldname | description | rationale |
| ------------------ | ----------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------- |
| room_id | Id of the room | Useful, when the API is called with an alias or to disambiguate multiple responses clientside. |
deepbluev7 marked this conversation as resolved.
Show resolved Hide resolved
| avatar_url | Avatar of the room | Copied from `publicRooms`. |
| guest_can_join | If guests can join the room. | Copied from `publicRooms`. |
| name | Name of the room | Copied from `publicRooms`. |
| num_joined_members | Member count of the room | Copied from `publicRooms`. |
| topic | Topic of the room | Copied from `publicRooms`. |
| world_readable | If the room history can be read without joining. | Copied from `publicRooms`. |
| join_rules | Join rules of the room | Copied from `publicRooms`. |
deepbluev7 marked this conversation as resolved.
Show resolved Hide resolved
| room_type | Optional. Type of the room, if any, i.e. `m.space` | Used to distinguish rooms from spaces. |
| is_direct | Optional. If this is a direct chat. The server should use the usual rules to figure out, if this is a direct chat, not just look in the create event. | May be used in previews to distinguish normal rooms from DMs. |
deepbluev7 marked this conversation as resolved.
Show resolved Hide resolved
| membership | The current membership of this user in the room. Usually `leave` if the room is fetched over federation. | Useful to distinguish invites and knocks from joined rooms. |
richvdh marked this conversation as resolved.
Show resolved Hide resolved
| is_encrypted | Optional. If the room is encrypted. This is already accessible as stripped state. Currently a bool, but maybe the algorithm makes more sense? | Some users may only want to join encrypted rooms or clients may want to filter out encrypted rooms, if they don't support encryption. |
deepbluev7 marked this conversation as resolved.
Show resolved Hide resolved

It should be possible to call this API without authentication, but servers may
rate limit how often they fetch information over federation more heavily, if the
user is unauthenticated. Also the fields `membership` and `is_direct` will be
missing.
t3chguy marked this conversation as resolved.
Show resolved Hide resolved

### Server-Server API

The Server-Server API mirrors the Client-Server API, with a few exceptions. The
`membership` and `is_direct` fields are never present. No `via` field is
necessary on the request, since servers should not forward the request to other
servers.

The server can't know, which user is requesting the summary. As such it should
apply visibility rules to check if any user on the requesting server would have
access to the summary.
deepbluev7 marked this conversation as resolved.
Show resolved Hide resolved

A request would be made as follows:

```
GET /_matrix/federation/v1/summary/{roomid}
```

The requesting server should cache the response to this request.

Note that the federation API only allows roomids and should use the usual
protocols to resolve the alias first, since it makes no sense to let anything
but the authoritive server for that alias resolve it.

## Potential issues

### Perfomance
deepbluev7 marked this conversation as resolved.
Show resolved Hide resolved

Clients may start calling this API very often instead of using the batched
summary API (MSC2946) for spaces or caching the state received via `/sync`.
deepbluev7 marked this conversation as resolved.
Show resolved Hide resolved
Looking up all the state events required for this API may cause performance
issues in that case.

To mitigate that, servers are recommended to cache the response for this API and
apply rate limiting if necessary.

## Alternatives

- The spaces summary API could be used, but it doesn't work for arbitrary rooms
and you always need to pass the parent space, without any control over the
rooms being returned.
deepbluev7 marked this conversation as resolved.
Show resolved Hide resolved
- The `/state` API could be used, but the response is much bigger than needed,
can't be cached as easily and may need more requests. This also doesn't work
over federation (yet).
Copy link
Member

@t3chguy t3chguy Jul 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the /state API also doesn't return stripped state events so would not have access to said data based on the Stripped State MSC https://matrix.org/docs/spec/client_server/r0.6.1#get-matrix-client-r0-rooms-roomid-state

The specific state API does return stripped state (because consistency, what's that) https://matrix.org/docs/spec/client_server/r0.6.1#get-matrix-client-r0-rooms-roomid-state-eventtype-statekey

But would require MANY API hits and not be able to reach all the data (e.g num_joined_members would not be possible)

- Peeking could solve this too, but with additional overhead and
[MSC2753](https://github.com/matrix-org/matrix-doc/pull/2753) is much more
complex.
deepbluev7 marked this conversation as resolved.
Show resolved Hide resolved

## Security considerations

This API may leak data, if implemented incorrectly or malicious servers could
return wrong results for a summary.
Comment on lines +234 to +235
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is true with any endpoint - the leak for this endpoint would more be that people could be surprised by the amount of metadata returned, such as in the case of matrix-org/matrix-spec#1186

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should I just delete that line? I do think it is a genuine concern.


Those are the same concerns as on [MSC2946](https://github.com/matrix-org/matrix-doc/pull/2946)
or [MSC3173](https://github.com/matrix-org/matrix-doc/pull/3173).

This API could also used for denial of service type attacks. Appropriate
ratelimiting and caching should be able to mitigate that.

## Unstable prefix

This uses the `im.nheko.summary` unstable prefix instead of the `summary` key in
the request paths during the MSC phase. As a result:

- the client API will be
`/_matrix/client/unstable/rooms/{roomidOrAlias}/im.nheko.summary`
- the federation API will be
`/_matrix/federation/unstable/im.nheko.summary/{roomid}`
t3chguy marked this conversation as resolved.
Show resolved Hide resolved