Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC4041 - Add Retry-After header notice. #1737

Merged
merged 9 commits into from
Mar 20, 2024
Merged

MSC4041 - Add Retry-After header notice. #1737

merged 9 commits into from
Mar 20, 2024

Conversation

Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot commented Mar 4, 2024 •
edited by github-actions bot
Loading

Pull Request Checklist

Signed-off-by: Will Hunt matrix@half-shot.uk

Preview: https://pr1737--matrix-spec-previews.netlify.app

@Half-Shot Half-Shot requested a review from a team as a code owner March 4, 2024 16:22
@richvdh
Copy link
Member

richvdh commented Mar 4, 2024

For links: MSC4041.

where did the template for that rather bizarre description come from?

@Half-Shot
Copy link
Contributor Author

For links: MSC4041.

where did the template for that rather bizarre description come from?

Err, I attempted to use GitHub codespaces for the first time, and I won't be using it again if it does things like this.

@turt2live turt2live mentioned this pull request Mar 4, 2024
Merged
@turt2live turt2live mentioned this pull request Mar 12, 2024
Closed
23 tasks
richvdh
richvdh requested changes Mar 13, 2024
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

content/client-server-api/_index.md Outdated Show resolved Hide resolved
content/client-server-api/_index.md Outdated Show resolved Hide resolved
content/client-server-api/_index.md Outdated Show resolved Hide resolved
@Half-Shot Half-Shot requested a review from richvdh March 13, 2024 14:49
richvdh
richvdh requested changes Mar 13, 2024
View reviewed changes
content/client-server-api/_index.md Outdated Show resolved Hide resolved
content/client-server-api/_index.md Outdated Show resolved Hide resolved
content/client-server-api/_index.md Outdated Show resolved Hide resolved
content/client-server-api/_index.md Outdated Show resolved Hide resolved
@Half-Shot Half-Shot requested a review from richvdh March 19, 2024 22:21
richvdh
richvdh requested changes Mar 19, 2024
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd land this myself, but I don't seem to have permission. So, please can you make the requested change?

@Half-Shot @richvdh
Update content/client-server-api/_index.md
46dbddb 
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@Half-Shot Half-Shot requested a review from richvdh March 20, 2024 09:40
richvdh
richvdh approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@Half-Shot @richvdh
Update changelogs/client_server/newsfragments/1737.feature
8def27a 
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@richvdh richvdh enabled auto-merge (squash) March 20, 2024 09:44
@richvdh richvdh merged commit e5aa523 into matrix-org:main Mar 20, 2024
12 checks passed
This was referenced Mar 22, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @richvdh