Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Sentry seems to no longer reports branches or commit hashes #12968

Closed
DMRobertson opened this issue Jun 6, 2022 · 2 comments · Fixed by #12973
Closed

Sentry seems to no longer reports branches or commit hashes #12968

DMRobertson opened this issue Jun 6, 2022 · 2 comments · Fixed by #12973
Assignees
@DMRobertson
Labels
X-Regression Something broke which worked on a previous release

Comments

@DMRobertson
Copy link
Contributor

See e.g. https://sentry.matrix.org/sentry/synapse-matrixorg/issues/10044/tags/release/ (internal users). I'd guess it was broken by poetry somehow. Particularly important for when matrix.org uses the matrix-org-hotfixes branch.
@DMRobertson
Copy link
Contributor Author

Seems to have happened between 1.56.0 and 1.57.1, judging by https://sentry.matrix.org/sentry/synapse-matrixorg/releases/

@DMRobertson DMRobertson self-assigned this Jun 6, 2022
@DMRobertson
Copy link
Contributor Author

Related: #11979, matrix-org/matrix-python-common#22

The problem seems to be that cwd = dist.locate_file(".") doesn't return the path to the Synapse checkout any more; instead, it refers to the virtualenv's site-packages directory. I think this is a fallback behaviour for when a package doesn't contain a given file?

Maybe we should just pass in synapse.__file__. as cwd explicitly.

@DMRobertson DMRobertson mentioned this issue Jun 6, 2022
Merged
DMRobertson pushed a commit that referenced this issue Jun 6, 2022
Fix Synapse git info missing in version strings
47e325a 
WIP.

Fixes #12968. Requires matrix-org/matrix-python-common#25
@DMRobertson DMRobertson mentioned this issue Jun 6, 2022
Merged
4 tasks
@H-Shay H-Shay added the X-Regression Something broke which worked on a previous release label Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DMRobertson DMRobertson

Labels
X-Regression Something broke which worked on a previous release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Synapse git info missing in version strings matrix-org/synapse
2 participants
@DMRobertson @H-Shay