Sort failing jobs in Complement CI to the top of the logs to make them easier to read.

[reivilibre]

This is an attempt at a quick fix to make the logs easier to read by collapsing adjacent successful jobs... GHA doesn't support nested groups :-(.

Instead this sorts the failing ones to the top so that they're easier to reach.
Unfortunately it only applies for each test suite (there are 2 of those)

[DMRobertson]

Won't block this, but my vote would be for doing this with a custom gotestfmt templater, see e.g. https://github.com/haveyoudebuggedit/gotestfmt#add-your-own-ci

[reivilibre]

Won't block this, but my vote would be for doing this with a custom gotestfmt templater, see e.g. haveyoudebuggedit/gotestfmt#add-your-own-ci

That's probably ideal, but it's probably taking it from a 5 minute job to a several hour job (especially if it's all in Go, since I'm definitely not very Go-native) :/

EDIT: actually it looks like some kind of templating language. I'll have a poke to see if it'd be easy enough to do

[DMRobertson]

I hope this wasn't too painful in the end 💚

I can see that skips are sorted above passes in CI, so LGTM.

Minor thoughts, which I leave to your discretion:

• Might be worth adding a link to the original template that this was based on as a comment in the template?
• Is this useful enough to keep it in <synapse repo>/.gotestfmt? I don't like cluttering the top-level directory, but maybe it makes running complement.sh by hand a more pleasant experience? Not sure.

[reivilibre]

Might be worth adding a link to the original template that this was based on as a comment in the template?

Good point.

running complement.sh by hand a more pleasant experience

I don't think this will do that, since you won't get the folding blocks anyway.
For by-hand usage, it's probably best to use the default template with the option that hides passing tests (I saw it around on the gotestfmt site and maybe we would do well to copy it to our docs.)