This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Only fire user_joined_room if the user has actually joined. #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 1, 2015 16:03
…y joined the room
Conflicts: synapse/handlers/federation.py synapse/handlers/room.py
| yield user_joined_room(self.distributor, user, event.room_id) | ||
| context = yield self.state_handler.compute_event_context( | ||
| event, old_state=state, outlier=event.internal_metadata.is_outlier() | ||
| ) |
There was a problem hiding this comment.
We already have the context as its returned by _handle_new_event (at line 180)
|
LGTM |
NegativeMjark
added a commit
that referenced
this pull request
Dec 2, 2015
Only fire user_joined_room if the user has actually joined.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synapse sends presence EDUs whenever a user joins the room. However it currently sends them whenever it sees a m.room.member event with membership join, even if the user was already joined to the room. This causes problems because setting the displayname results in a new join event for each room the user is a member of, which in turn will cause synapse to send an EDU for each remote server joined to each of those rooms.
This PR should fix this by only notifying if the user wasn't already joined to the room.