Fix the CAS login test #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
richvdh
approved these changes
Mar 24, 2020
| # the redirectUrl we send to /login/cas/redirect, which is where we | ||
| # hope to get redirected back to | ||
| my $REDIRECT_URL = "https://client?p=http%3A%2F%2Fserver"; | ||
|
|
||
| my $HS_URI = $homeserver_info->client_location . "/_matrix/client/r0/login/cas/ticket?redirectUrl=" . uri_escape($REDIRECT_URL); |
There was a problem hiding this comment.
should we not just check that the service provided to cas/proxyValidate matches that given to cas/login, rather than hardcoding what we expect it to be?
anoadragon453
added a commit
that referenced
this pull request
Apr 27, 2020
…rite_whitelist_annotation * 'develop' of github.com:matrix-org/sytest: (42 commits) Fix OFFLINE support for the sytest-synapse docker image (#858) Add support for running worker mode against redis (#857) route GET account_data requests to client_reader (#855) Test that users receive updates for their own devices (#854) Add tests for SSO + user interactive authentication. (#845) Modify login tests to be spec compliant Make message history pagination test less flaky (#851) Small comment fixes for consistency (#808) Change room_fixture to run matrix_create_room_synced by default (#848) Update dendrite docs with new whitelist/blacklist info (#849) Add test for querying remote public rooms list with local server_name (#847) Add more logging to "Guest user can set display names" (#846) Add test for updating room aliases on upgraded room join (#844) Add tests to ensure that the operation cannot be modified during interactive auth. (#830) fix the CAS login test (#829) Update NOT_FOUND error to BAD_ALIAS error to be spec compliant. (#837) Missing bits Use r0 instead of 'unstable' for joined_members|rooms Add test to optionally keep other sessions when modifying a user's password. (#832) Remove tests that call query_auth endpoint. (#827) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see matrix-org/synapse#6634
Signed-off-by: Erik erik.gto@googlemail.com